Help compiler enforce nullability annotations (#32090)
authorJulien Couvreur <jcouv@users.noreply.github.com>
Fri, 14 Feb 2020 16:14:42 +0000 (08:14 -0800)
committerGitHub <noreply@github.com>
Fri, 14 Feb 2020 16:14:42 +0000 (08:14 -0800)
commit0f834db1fd80cf82e5ef27f72c48af1c911775da
tree63cc1a6c21e007d09386e95510376c3332ecc04e
parenteedeeb628aa703a114940fd40cf0c538f9ec454b
Help compiler enforce nullability annotations (#32090)

* Help compiler enforce nullability annotations

* Revert repro changes

* Simplifications

* Address feedback

* Tweak

* Another cleanup

* Fixup on ImportTypes

* Revert from T? to [AllowNull]T

* Enable nullability on one file

* Addressing PR feedback from Stephen

* Use Debug.Assert instead of pragma

* Revert "Use Debug.Assert instead of pragma"

This reverts commit f7175ba5427729ce60c898d5e7f00d9a4550e12d.
36 files changed:
src/coreclr/src/System.Private.CoreLib/src/System/Environment.CoreCLR.cs
src/libraries/Common/src/System/Collections/Generic/ReferenceEqualityComparer.cs
src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/IImmutableListQueries.cs
src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/ImmutableHashSet_1.cs
src/libraries/System.Collections/src/System/Collections/Generic/HashSetEqualityComparer.cs
src/libraries/System.Collections/src/System/Collections/Generic/SortedSet.TreeSubSet.cs
src/libraries/System.Collections/src/System/Collections/Generic/SortedSet.cs
src/libraries/System.Collections/src/System/Collections/Generic/SortedSetEqualityComparer.cs
src/libraries/System.ComponentModel.Composition/src/Microsoft/Internal/Collections/CollectionServices.cs
src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Primitives/ComposablePartDefinition.cs
src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/ReflectionModel/ImportType.cs
src/libraries/System.Linq.Expressions/src/System/Dynamic/Utils/CollectionExtensions.cs
src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/Interpreter/LightCompiler.cs
src/libraries/System.Linq.Parallel/src/System/Linq/Parallel/Partitioning/HashRepartitionStream.cs
src/libraries/System.Linq.Parallel/src/System/Linq/Parallel/QueryOperators/Unary/ForAllOperator.cs
src/libraries/System.Linq.Parallel/src/System/Linq/Parallel/Utils/HashLookup.cs
src/libraries/System.Linq.Parallel/src/System/Linq/Parallel/Utils/ReverseComparer.cs
src/libraries/System.Linq.Parallel/src/System/Linq/Parallel/Utils/WrapperEqualityComparer.cs
src/libraries/System.Linq/src/System/Linq/Partition.SpeedOpt.cs
src/libraries/System.Private.CoreLib/src/System/Action.cs
src/libraries/System.Private.CoreLib/src/System/Collections/Generic/Comparer.cs
src/libraries/System.Private.CoreLib/src/System/Collections/Generic/IEqualityComparer.cs
src/libraries/System.Private.CoreLib/src/System/Diagnostics/DebugProvider.cs
src/libraries/System.Private.CoreLib/src/System/HashCode.cs
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MemoryMarshal.cs
src/libraries/System.Private.CoreLib/src/System/SpanHelpers.BinarySearch.cs
src/libraries/System.Reflection.Metadata/src/System/Reflection/Internal/Utilities/ByteSequenceComparer.cs
src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/General/RoAssemblyName.cs
src/libraries/System.Resources.Writer/src/System/Resources/__FastResourceComparer.cs
src/libraries/System.Runtime.Extensions/ref/System.Runtime.Extensions.cs
src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/ObjectProgress.cs
src/libraries/System.Runtime/ref/System.Runtime.cs
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReferenceEqualsEqualityComparer.cs
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs
src/mono/netcore/System.Private.CoreLib/src/System/TypeIdentifier.cs