elm_transit: remove unnecessary image preload invocation
authorShinwoo Kim <cinoo.kim@samsung.com>
Mon, 17 Feb 2020 12:29:56 +0000 (21:29 +0900)
committerHermet Park <hermetpark@gmail.com>
Mon, 17 Feb 2020 12:31:52 +0000 (21:31 +0900)
commit0f61f90d59331b0440e6d8c4cfe61bbb87b52b00
tree6ca78b093f1d3a7001738fc324337a2a97163f0c
parent58037abffeb1c31ffde613e6863f4432d4fb5df9
elm_transit: remove unnecessary image preload invocation

Summary:
If user uses image object with following step, then unnecessary preloading
related line is invocated in elm_image_file_set.

elm_image_file_set(obj, file, NULL)
elm_icon_preload_disabled_set(obj, EINA_TRUE)

The following is the preloading related line triggered by elm_image_file_set.

(#0) _image_preload_internal
(#1) _evas_image_load_async_start
(#2) evas_object_image_preload
(#3) _efl_ui_image_smart_internal_file_set
(#4) _efl_ui_image_efl_file_load
(#5) efl_file_load
(#6) efl_file_simple_load
(#7) elm_image_file_set

Moreover there is a flickering issue caused by the unnecessary preloading.
A test code is attached.

Test Plan:
Use following test code. The flickering issue occurs with `ELM_SCALE=10 ELM_ACCEL=gl ./test_transit`
{F3847288}

Reviewers: Hermet, jsuya

Reviewed By: Hermet, jsuya

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11364

Change-Id: I46f2acaa475a465b2a71c9a4e8911ca6c43af55f
src/lib/elementary/elm_transit.c