rtc: 88pm80x: fix unintended sign extension
authorColin Ian King <colin.king@canonical.com>
Wed, 6 Feb 2019 10:08:11 +0000 (10:08 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:50:20 +0000 (14:50 +0100)
commit0f45d44655c211d172884968d4f2cacef72a276b
tree54180b4c73d205afcaad4acb6086b6800950a157
parent4260a44a7d4e54faa974cb21d42e9ae752b52392
rtc: 88pm80x: fix unintended sign extension

[ Upstream commit fb0b322537a831b5b0cb948c56f8f958ce493d3a ]

Shifting a u8 by 24 will cause the value to be promoted to an integer. If
the top bit of the u8 is set then the following conversion to an unsigned
long will sign extend the value causing the upper 32 bits to be set in
the result.

Fix this by casting the u8 value to an unsigned long before the shift.

Detected by CoverityScan, CID#714646-714649 ("Unintended sign extension")

Fixes: 2985c29c1964 ("rtc: Add rtc support to 88PM80X PMIC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-88pm80x.c