Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"
authorMarek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Tue, 22 Feb 2022 00:18:16 +0000 (01:18 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 24 Feb 2022 16:58:37 +0000 (08:58 -0800)
commit0f4558ae91870692ce7f509c31c9d6ee721d8cdc
treefa3ee24888963e5d6560957085abb8bf4308e9ce
parent5facf49702b6d994d3f1c72cffa0e83f3858ee19
Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"

This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2.

The 'hotplug-status' node should not be removed as long as the vif
device remains configured. Otherwise the xen-netback would wait for
re-running the network script even if it was already called (in case of
the frontent re-connecting). But also, it _should_ be removed when the
vif device is destroyed (for example when unbinding the driver) -
otherwise hotplug script would not configure the device whenever it
re-appear.

Moving removal of the 'hotplug-status' node was a workaround for nothing
calling network script after xen-netback module is reloaded. But when
vif interface is re-created (on xen-netback unbind/bind for example),
the script should be called, regardless of who does that - currently
this case is not handled by the toolstack, and requires manual
script call. Keeping hotplug-status=connected to skip the call is wrong
and leads to not configured interface.

More discussion at
https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Link: https://lore.kernel.org/r/20220222001817.2264967-1-marmarek@invisiblethingslab.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/xen-netback/xenbus.c