mesa: Set gl_fragment_program::UsesKill in do_set_program_inouts.
authorPaul Berry <stereotype441@gmail.com>
Thu, 19 Jul 2012 06:18:14 +0000 (23:18 -0700)
committerPaul Berry <stereotype441@gmail.com>
Fri, 20 Jul 2012 16:33:07 +0000 (09:33 -0700)
commit0f1f2ff8db8c19be27b9f51f07134091e109e4b2
tree170072da554c3850fe4bb5d4f2773ae5b537ad88
parenta8c092266e9885f3370bbeae15bd80ebf035d05d
mesa: Set gl_fragment_program::UsesKill in do_set_program_inouts.

Previously, the code for setting this flag for GLSL programs was
duplicated in three places: brw_link_shader(), glsl_to_tgsi_visitor,
and ir_to_mesa_visitor.  In addition to the unnecessary duplication,
there was a performance problem on i965: brw_link_shader() set the
flag before doing its final round of optimizations, which meant that
if the optimizations managed to eliminate all the discard operations,
the flag would still be set, resulting (at least in theory) in slower
performance.

This patch consolidates all of the code that sets UsesKill for GLSL
programs into do_set_program_inouts(), which already is doing a
similar job for UsesDFdy, and which occurs after i965's final round of
optimizations.

Non-GLSL programs (ARB programs and the state tracker's glBitmap
program) are unaffected.

Reviewed-by: Eric Anholt <eric@anholt.net>
src/glsl/ir_set_program_inouts.cpp
src/mesa/drivers/dri/i965/brw_shader.cpp
src/mesa/program/ir_to_mesa.cpp
src/mesa/state_tracker/st_glsl_to_tgsi.cpp