splice, net: Fix splice_to_socket() for O_NONBLOCK socket
authorJan Stancek <jstancek@redhat.com>
Mon, 24 Jul 2023 17:39:04 +0000 (19:39 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 27 Jul 2023 04:56:06 +0000 (21:56 -0700)
commit0f0fa27b871b53a62c3cd2b054ebcce199277310
tree5fe5a5214997c800a54f43a199a6a52fed035072
parent15cec633fc7bfe4cd69aa012c3b35b31acfc86f2
splice, net: Fix splice_to_socket() for O_NONBLOCK socket

LTP sendfile07 [1], which expects sendfile() to return EAGAIN when
transferring data from regular file to a "full" O_NONBLOCK socket,
started failing after commit 2dc334f1a63a ("splice, net: Use
sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage()").
sendfile() no longer immediately returns, but now blocks.

Removed sock_sendpage() handled this case by setting a MSG_DONTWAIT
flag, fix new splice_to_socket() to do the same for O_NONBLOCK sockets.

[1] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/sendfile/sendfile07.c

Fixes: 2dc334f1a63a ("splice, net: Use sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage()")
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Jan Stancek <jstancek@redhat.com>
Tested-by: Xi Ruoyao <xry111@xry111.site>
Link: https://lore.kernel.org/r/023c0e21e595e00b93903a813bc0bfb9a5d7e368.1690219914.git.jstancek@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
fs/splice.c