livepatch: Nullify obj->mod in klp_module_coming()'s error path
authorMiroslav Benes <mbenes@suse.cz>
Fri, 19 Jul 2019 12:28:39 +0000 (14:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 16:57:10 +0000 (18:57 +0200)
commit0f0ced702d53d211d3dca8211d31a3bfddb33e27
treea8e32ed3a59cdb70daeee8f05a9364e547d76653
parent78a1138672afb95d21746de64a779f2c3357d7b7
livepatch: Nullify obj->mod in klp_module_coming()'s error path

[ Upstream commit 4ff96fb52c6964ad42e0a878be8f86a2e8052ddd ]

klp_module_coming() is called for every module appearing in the system.
It sets obj->mod to a patched module for klp_object obj. Unfortunately
it leaves it set even if an error happens later in the function and the
patched module is not allowed to be loaded.

klp_is_object_loaded() uses obj->mod variable and could currently give a
wrong return value. The bug is probably harmless as of now.

Signed-off-by: Miroslav Benes <mbenes@suse.cz>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/livepatch/core.c