drm/sun4i: Fix crash during suspend after component bind failure
authorSamuel Holland <samuel@sholland.org>
Wed, 15 Jun 2022 05:42:53 +0000 (00:42 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jun 2022 07:03:22 +0000 (09:03 +0200)
commit0eef1dcb97744dc7db95b06e90b64be5b651fbf1
treea9c592a70fc19192c59fed6e774a04d40b3b4e23
parentb03607437ea81b850599f705096b05b85e7a4a71
drm/sun4i: Fix crash during suspend after component bind failure

[ Upstream commit 1342b5b23da9559a1578978eaff7f797d8a87d91 ]

If the component driver fails to bind, or is unbound, the driver data
for the top-level platform device points to a freed drm_device. If the
system is then suspended, the driver passes this dangling pointer to
drm_mode_config_helper_suspend(), which crashes.

Fix this by only setting the driver data while the platform driver holds
a reference to the drm_device.

Fixes: 624b4b48d9d8 ("drm: sun4i: Add support for suspending the display driver")
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220615054254.16352-1-samuel@sholland.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/sun4i/sun4i_drv.c