net: bgmac: Drop free_netdev() from bgmac_enet_remove()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 9 Nov 2022 15:01:36 +0000 (15:01 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 26 Nov 2022 08:24:38 +0000 (09:24 +0100)
commit0ee6455c9cfa6af2dddc2701673ccaf5fb0bd7d2
tree738b5bc30d35c135dbd25c304155b19a50509a94
parent7ff4fa179e4e678cb6b423d8106657285c58d0af
net: bgmac: Drop free_netdev() from bgmac_enet_remove()

[ Upstream commit 6f928ab8ee9bfbcb0e631c47ea8a16c3d5116ff1 ]

netdev is allocated in bgmac_alloc() with devm_alloc_etherdev() and will
be auto released in ->remove and ->probe failure path. Using free_netdev()
in bgmac_enet_remove() leads to double free.

Fixes: 34a5102c3235 ("net: bgmac: allocate struct bgmac just once & don't copy it")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20221109150136.2991171-1-weiyongjun@huaweicloud.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bgmac.c