powerpc/interrupt: Don't read MSR from interrupt_exit_kernel_prepare()
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Mon, 5 Jun 2023 08:55:26 +0000 (10:55 +0200)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 9 Jun 2023 13:29:51 +0000 (23:29 +1000)
commit0eb089a72fda3f7969e6277804bde75dc1474a14
treefbfafa2ce8546fa91db5ca77ac0c549317f3ddfc
parent396f2b0106ff343c61f7ae221dc6ae300f807760
powerpc/interrupt: Don't read MSR from interrupt_exit_kernel_prepare()

A disassembly of interrupt_exit_kernel_prepare() shows a useless read
of MSR register. This is shown by r9 being re-used immediately without
doing anything with the value read.

  c000e0e0:       60 00 00 00     nop
  c000e0e4:       7d 3a c2 a6     mfmd_ap r9
  c000e0e8:       7d 20 00 a6     mfmsr   r9
  c000e0ec:       7c 51 13 a6     mtspr   81,r2
  c000e0f0:       81 3f 00 84     lwz     r9,132(r31)
  c000e0f4:       71 29 80 00     andi.   r9,r9,32768

This is due to the use of local_irq_save(). The flags read by
local_irq_save() are never used, use local_irq_disable() instead.

Fixes: 13799748b957 ("powerpc/64: use interrupt restart table to speed up return from interrupt")
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/df36c6205ab64326fb1b991993c82057e92ace2f.1685955214.git.christophe.leroy@csgroup.eu
arch/powerpc/kernel/interrupt.c