scsi: pm80xx: fix logic to break out of loop when register value is 2 or 3
authorColin Ian King <colin.king@canonical.com>
Wed, 20 Nov 2019 13:50:31 +0000 (13:50 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 27 Nov 2019 02:30:12 +0000 (21:30 -0500)
commit0e7c353e1828819eb92af0a64fc9b2f4f778b76e
treefd945aeeb00d0282f3c715ae2f3454a8e9f5dc2a
parent82ea3e0e129e2ab913dd6684bab7a6e5e9896dee
scsi: pm80xx: fix logic to break out of loop when register value is 2 or 3

The condition (reg_val != 2) || (reg_val != 3) will always be true because
reg_val cannot be equal to two different values at the same time. Fix this
by replacing the || operator with && so that the loop will loop if reg_val
is not a 2 and not a 3 as was originally intended.

Fixes: 50dc2f221455 ("scsi: pm80xx: Modified the logic to collect fatal dump")
Link: https://lore.kernel.org/r/20191120135031.270708-1-colin.king@canonical.com
Addresses-Coverity: ("Constant expression result")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm80xx_hwi.c