bridge: multicast: add sanity check for query source addresses
authorLinus Lüssing <linus.luessing@web.de>
Tue, 4 Mar 2014 02:57:35 +0000 (03:57 +0100)
committerSeokYeon Hwang <syeon.hwang@samsung.com>
Wed, 7 May 2014 06:30:56 +0000 (15:30 +0900)
commit0e6986ba7b8d6fcbaace946883635b36286917a6
tree160e2fbd0c79eee086bbbd8e211e73d8754a7f38
parente649b7880ec523f8a94666eceb1554cf11d6b5ad
bridge: multicast: add sanity check for query source addresses

[ Upstream commit 6565b9eeef194afbb3beec80d6dd2447f4091f8c ]

MLD queries are supposed to have an IPv6 link-local source address
according to RFC2710, section 4 and RFC3810, section 5.1.14. This patch
adds a sanity check to ignore such broken MLD queries.

Without this check, such malformed MLD queries can result in a
denial of service: The queries are ignored by any MLD listener
therefore they will not respond with an MLD report. However,
without this patch these malformed MLD queries would enable the
snooping part in the bridge code, potentially shutting down the
according ports towards these hosts for multicast traffic as the
bridge did not learn about these listeners.

Reported-by: Jan Stancek <jstancek@redhat.com>
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Reviewed-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/bridge/br_multicast.c