crypto: atmel-{aes,sha} - Fix incorrect use of dmaengine_terminate_all()
authorTudor Ambarus <tudor.ambarus@microchip.com>
Fri, 13 Dec 2019 09:54:42 +0000 (09:54 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 20 Dec 2019 06:58:34 +0000 (14:58 +0800)
commit0e69378940eafe386464679a84856d1b63e1bac2
treef2e10f30595cc313c2103cbb1c2c131ae4a1e8d5
parent7d07de2c18abd95f72efb28f78a4825e0fc1aa6a
crypto: atmel-{aes,sha} - Fix incorrect use of dmaengine_terminate_all()

device_terminate_all() is used to abort all the pending and
ongoing transfers on the channel, it should be used just in the
error path.

Also, dmaengine_terminate_all() is deprecated and one should use
dmaengine_terminate_async() or dmaengine_terminate_sync(). The method
is not used in atomic context, use dmaengine_terminate_sync().

A secondary aspect of this patch is that it luckily avoids a deadlock
between atmel_aes and at_hdmac.c. While in tasklet with the lock held,
the dma controller invokes the client callback (dmaengine_terminate_all),
which tries to get the same lock. The at_hdmac fix would be to drop the
lock before invoking the client callback, a fix on at_hdmac will follow.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/atmel-aes.c
drivers/crypto/atmel-sha.c