accel/qaic: initialize ret variable to 0
authorTom Rix <trix@redhat.com>
Wed, 17 May 2023 16:56:05 +0000 (10:56 -0600)
committerJeffrey Hugo <quic_jhugo@quicinc.com>
Tue, 23 May 2023 15:43:11 +0000 (09:43 -0600)
commit0e163e54c34c12369ccf6562e74e8f0a800f4aad
treedaca5f8f411b70dabc257f94f1624721c0a15890
parentc21f11d182c2180d8b90eaff84f574cfa845b250
accel/qaic: initialize ret variable to 0

clang static analysis reports
drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage
  value returned to caller [core.uninitialized.UndefReturn]
        return ret;
        ^~~~~~~~~~

From a code analysis of the function, the ret variable is only set some
of the time but is always returned.  This suggests ret can return
uninitialized garbage. However BO allocation will ensure ret is always
set in reality.

Initialize ret to 0 to silence the warning.

Fixes: ff13be830333 ("accel/qaic: Add datapath")
Signed-off-by: Tom Rix <trix@redhat.com>
[jhugo: Reword commit text]
Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
Reviewed-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230517165605.16770-1-quic_jhugo@quicinc.com
drivers/accel/qaic/qaic_data.c