Web Inspector: popover is not shown for detached DOM nodes, not referenced directly...
authoryurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Jun 2012 12:32:38 +0000 (12:32 +0000)
committeryurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Jun 2012 12:32:38 +0000 (12:32 +0000)
commit0e0a75a0a7a9eb61faa72a74c01411e80662e16f
tree1add35caf314b29059770977824b7b0adc500fab
parent93b094186158ec14c675c8086f92b53be742ee11
Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
https://bugs.webkit.org/show_bug.cgi?id=89955

Reviewed by Vsevolod Vlasov.

Show object popover for all heap snapshot nodes event for those whose
canBeQueried flag is false. We didn't show popover for such objects before
as it could lead to the backend crash. In the meantime the backend shouldn't
fail on such DOM wrappers and report an error if it cannot resolve
inspected object.

* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js
Source/WebCore/inspector/front-end/HeapSnapshotView.js