[clangd] Value initialize SymbolIDs
authorKadir Cetinkaya <kadircet@google.com>
Thu, 29 Oct 2020 15:04:53 +0000 (16:04 +0100)
committerKadir Cetinkaya <kadircet@google.com>
Mon, 2 Nov 2020 10:37:47 +0000 (11:37 +0100)
commit0df197516b69a4477a4c8f02b7c4dccacda5f23f
tree4a8c6888cc4b8440228e8c7828988b64a522350b
parent1ed2ca68191fb280161ee8f8cd080640db6be710
[clangd] Value initialize SymbolIDs

We were default initializing SymbolIDs before, which would leave
indeterminate values in underlying std::array.

This patch updates the underlying data initalization to be value-init and adds a
way to check for validness of a SymbolID.

Differential Revision: https://reviews.llvm.org/D90397
15 files changed:
clang-tools-extra/clangd/AST.cpp
clang-tools-extra/clangd/AST.h
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/clangd/CollectMacros.cpp
clang-tools-extra/clangd/HeaderSourceSwitch.cpp
clang-tools-extra/clangd/Hover.cpp
clang-tools-extra/clangd/IncludeFixer.cpp
clang-tools-extra/clangd/Protocol.cpp
clang-tools-extra/clangd/Protocol.h
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra/clangd/index/SymbolCollector.cpp
clang-tools-extra/clangd/index/SymbolID.h
clang-tools-extra/clangd/refactor/Rename.cpp
clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp
clang-tools-extra/clangd/unittests/HoverTests.cpp