ixgbe: don't clear_bit on xdp_ring->state if xdp_ring is null
authorColin Ian King <colin.king@canonical.com>
Thu, 4 Oct 2018 17:57:32 +0000 (18:57 +0100)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 7 Nov 2018 17:47:00 +0000 (09:47 -0800)
commit0db4a47c05e6b5f7dda2a5d8b213ade5373afa49
tree09815659bd83bfc3a8a90dc0b680d2922f3d9c98
parentb86077207d0c08e181c7715bc75f50a3ad2fdf74
ixgbe: don't clear_bit on xdp_ring->state if xdp_ring is null

There is an earlier check to see if xdp_ring is null when configuring
the tx ring, so assuming that it can still be null, the clearing of
the xdp_ring->state currently could end up with a null pointer
dereference.  Fix this by only clearing the bit if xdp_ring is not null.

Detected by CoverityScan, CID#1473795 ("Dereference after null check")

Fixes: 024aa5800f32 ("ixgbe: added Rx/Tx ring disable/enable functions")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c