random: do not sign extend bytes for rotation when mixing
authorJason A. Donenfeld <Jason@zx2c4.com>
Fri, 24 Dec 2021 18:17:58 +0000 (19:17 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Thu, 6 Jan 2022 23:25:25 +0000 (00:25 +0100)
commit0d9488ffbf2faddebc6bac055bfa6c93b94056a3
tree5a2001dbfd86c2f2e65cb37c75f560d515a53852
parent9f9eff85a008b095eafc5f4ecbaf5aca689271c1
random: do not sign extend bytes for rotation when mixing

By using `char` instead of `unsigned char`, certain platforms will sign
extend the byte when `w = rol32(*bytes++, input_rotate)` is called,
meaning that bit 7 is overrepresented when mixing. This isn't a real
problem (unless the mixer itself is already broken) since it's still
invertible, but it's not quite correct either. Fix this by using an
explicit unsigned type.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
drivers/char/random.c