Enable stylecop warnings 1205, 1212, and 1617 (dotnet/corefx#39941)
authorStephen Toub <stoub@microsoft.com>
Thu, 1 Aug 2019 22:00:12 +0000 (18:00 -0400)
committerGitHub <noreply@github.com>
Thu, 1 Aug 2019 22:00:12 +0000 (18:00 -0400)
commit0d8a87d1ddaefc481b7be29d65f823e4b140c446
tree08342c07815022ab344b4e5e6db88db978f09731
parentfb4d480ed5a4d2df58f6c4395a4c4613de641d1c
Enable stylecop warnings 1205, 1212, and 1617 (dotnet/corefx#39941)

* Enable stylecop warning 1617 (void return value should not be documented)

* Enable stylecop warning 1212 (get/set accessor ordering)

* Enable stylecop warning 1205 (modifier ordering)

Commit migrated from https://github.com/dotnet/corefx/commit/6074cfc995d7968fcdbc7f707acff0c6284c6ae9
213 files changed:
src/libraries/CodeAnalysis.ruleset
src/libraries/Common/src/Interop/BSD/System.Native/Interop.ProtocolStatistics.cs
src/libraries/Common/src/Interop/BSD/System.Native/Interop.Sysctl.cs
src/libraries/Common/src/Interop/FreeBSD/Interop.Process.cs
src/libraries/Common/src/Interop/OSX/Interop.CoreFoundation.cs
src/libraries/Common/src/Interop/OSX/Interop.RunLoop.cs
src/libraries/Common/src/Interop/OSX/System.Security.Cryptography.Native.Apple/Interop.Ssl.cs
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.EVP.cs
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Hmac.cs
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Rsa.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.CloseServiceHandle.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.ControlService.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.CreateService.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.DeleteService.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.EnumDependentServices.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.EnumServicesStatusEx.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.LookupAccountSid.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.OpenSCManager.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.OpenService.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.QueryServiceConfig.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.RegisterServiceCtrlHandlerEx.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.SetServiceStatus.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.StartService.cs
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.StartServiceCtrlDispatcher.cs
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CertAddCertificateLinkToStore.cs
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.GetNetworkParams.cs
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.ICMP.cs
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.if_nametoindex.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FlushViewOfFile.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetCPInfoEx.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetConsoleCP.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetConsoleMode.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetConsoleOutputCP.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetCurrentProcessId.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetCurrentThread.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetFileType_IntPtr.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetNativeSystemInfo.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetOverlappedResult.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GlobalMemoryStatusEx.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.SetConsoleCP.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.SetConsoleOutputCP.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.SetConsoleTextAttribute.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.UnmapViewOfFile.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.VirtualAlloc.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.VirtualQuery.cs
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.WaitCommEvent.cs
src/libraries/Common/src/Interop/Windows/Mincore/Interop.GetCommPorts.cs
src/libraries/Common/src/Interop/Windows/Mincore/Interop.VirtualAllocFromApp.cs
src/libraries/Common/src/Interop/Windows/Version/Interop.GetFileVersionInfoEx.cs
src/libraries/Common/src/Interop/Windows/Version/Interop.GetFileVersionInfoSizeEx.cs
src/libraries/Common/src/Interop/Windows/Version/Interop.VerQueryValue.cs
src/libraries/Common/src/System/Data/Common/NameValuePair.cs
src/libraries/Common/tests/System/Net/Http/Http2LoopbackServer.cs
src/libraries/System.ComponentModel.Composition/src/Microsoft/Internal/GenerationServices.cs
src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Primitives/ComposablePartDefinition.cs
src/libraries/System.Composition.TypedParts/tests/ContainerConfigurationTests.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationManagerInternalFactory.cs
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/SettingsProviderCollection.cs
src/libraries/System.Configuration.ConfigurationManager/tests/Mono/ConfigurationSaveTest.cs
src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/TempConfigurationHost.cs
src/libraries/System.Console/tests/ConsoleEncoding.Windows.cs
src/libraries/System.Data.Common/src/System/Data/DataSetUtil.cs
src/libraries/System.Data.Common/src/System/Data/DataTableExtensions.cs
src/libraries/System.Data.Common/src/System/Data/xmlsaver.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/Common/AdapterUtil.Odbc.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/Odbc32.cs
src/libraries/System.Data.OleDb/src/AdapterSwitches.cs
src/libraries/System.Data.OleDb/src/DbConnectionOptions.cs
src/libraries/System.Data.OleDb/src/DbPropSet.cs
src/libraries/System.Data.OleDb/src/NativeMethods.cs
src/libraries/System.Data.OleDb/src/OleDbCommand.cs
src/libraries/System.Data.OleDb/src/OleDbCommandBuilder.cs
src/libraries/System.Data.OleDb/src/OleDbConnection.cs
src/libraries/System.Data.OleDb/src/OleDbConnectionInternal.cs
src/libraries/System.Data.OleDb/src/OleDbConnectionString.cs
src/libraries/System.Data.OleDb/src/OleDbDataAdapter.cs
src/libraries/System.Data.OleDb/src/OleDbDataReader.cs
src/libraries/System.Data.OleDb/src/OleDbEnumerator.cs
src/libraries/System.Data.OleDb/src/OleDbError.cs
src/libraries/System.Data.OleDb/src/OleDbErrorCollection.cs
src/libraries/System.Data.OleDb/src/OleDbException.cs
src/libraries/System.Data.OleDb/src/OleDbInfoMessageEvent.cs
src/libraries/System.Data.OleDb/src/OleDbParameter.cs
src/libraries/System.Data.OleDb/src/OleDbPropertySetGuid.cs
src/libraries/System.Data.OleDb/src/OleDbRowUpdatedEvent.cs
src/libraries/System.Data.OleDb/src/OleDbRowUpdatingEvent.cs
src/libraries/System.Data.OleDb/src/OleDbSchemaGuid.cs
src/libraries/System.Data.OleDb/src/OleDbTransaction.cs
src/libraries/System.Data.OleDb/src/OleDb_Enum.cs
src/libraries/System.Data.OleDb/src/OleDb_Util.cs
src/libraries/System.Data.OleDb/src/PropertyIDSet.cs
src/libraries/System.Data.OleDb/src/RowBinding.cs
src/libraries/System.Data.OleDb/src/SafeHandles.cs
src/libraries/System.Data.OleDb/src/SafeNativeMethods.cs
src/libraries/System.Data.OleDb/src/System/Data/Common/AdapterUtil.cs
src/libraries/System.Data.OleDb/src/System/Data/Common/NameValuePair.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionPool.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionPoolCounters.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionPoolIdentity.cs
src/libraries/System.Data.OleDb/src/UnsafeNativeMethods.cs
src/libraries/System.Data.SqlClient/src/System/Data/Common/AdapterUtil.SqlClient.cs
src/libraries/System.Data.SqlClient/src/System/Data/ProviderBase/DbConnectionPool.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNIProxy.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlBulkCopy.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlCommand.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlCommandBuilder.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlConnection.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlDataAdapter.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlFileStream.Windows.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlInternalConnection.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlParameterCollection.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlRowUpdatedEvent.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlRowUpdatingEvent.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlSequentialTextReader.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlTransaction.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlUtil.cs
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/TdsParser.cs
src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/PerformanceData/CounterSetInstance.cs
src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/PerformanceData/CounterSetInstanceCounterDataSet.cs
src/libraries/System.Diagnostics.Process/tests/Interop.cs
src/libraries/System.Diagnostics.Process/tests/ProcessThreadTests.Windows.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/ADUtils.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/RangeRetriever.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/SDSUtils.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AuthenticablePrincipal.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Computer.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Context.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/ExtensionHelper.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/GlobalConfig.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/GlobalDebug.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Group.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/IdentityClaim.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/IdentityType.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Principal.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/QbeFilterDescription.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/SAM/SAMUtils.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/UnknownPrincipal.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/UrnScheme.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/User.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Utils.cs
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/interopt.cs
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/UnsafeNativeMethods.cs
src/libraries/System.Drawing.Common/src/System/Drawing/Graphics.Unix.cs
src/libraries/System.Drawing.Common/src/System/Drawing/LibX11Functions.cs
src/libraries/System.Drawing.Common/src/System/Drawing/MarshallingHelpers.cs
src/libraries/System.Globalization/tests/CultureInfo/CultureInfoAll.cs
src/libraries/System.IO.Packaging/src/System/IO/Packaging/PackagingUtilities.cs
src/libraries/System.IO.Packaging/src/System/IO/Packaging/XmlCompatibilityReader.cs
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.Unix.cs
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.Windows.cs
src/libraries/System.IO/tests/Stream/Stream.NullTests.cs
src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/Interpreter/TypeOperations.cs
src/libraries/System.Linq.Parallel/src/System/Linq/Parallel/QueryOperators/Unary/TakeOrSkipWhileQueryOperator.cs
src/libraries/System.Management/src/System/Management/ManagementClass.cs
src/libraries/System.Management/src/System/Management/WMIGenerator.cs
src/libraries/System.Net.Http/src/System/Net/Http/CurlHandler/CurlResponseHeaderReader.cs
src/libraries/System.Net.Http/src/System/Net/Http/Headers/KnownHeaders.cs
src/libraries/System.Net.Http/src/System/Net/Http/Headers/ObjectCollection.cs
src/libraries/System.Net.HttpListener/src/System/Net/Windows/WebSockets/WebSocketBase.cs
src/libraries/System.Net.Mail/src/System/Net/Mail/SmtpClient.cs
src/libraries/System.Net.Security/tests/FunctionalTests/NegotiateStreamKerberosTest.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/BaseOverlappedAsyncResult.Windows.cs
src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlCanonicalWriter.cs
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlNodeWriter.cs
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlUTF8TextWriter.cs
src/libraries/System.Private.Xml/src/System/Xml/Schema/DataTypeImplementation.cs
src/libraries/System.Private.Xml/src/System/Xml/Schema/Inference/Infer.cs
src/libraries/System.Private.Xml/src/System/Xml/XmlCharType.cs
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Runtime/XmlQuerySequence.cs
src/libraries/System.Reflection.Extensions/tests/Definitions/ConstructorDefinitions.cs
src/libraries/System.Reflection.Extensions/tests/Definitions/EventDefinitions.cs
src/libraries/System.Reflection.Extensions/tests/Definitions/FieldDefinitions.cs
src/libraries/System.Reflection.Extensions/tests/Definitions/MethodDefinitions.cs
src/libraries/System.Reflection.Extensions/tests/Definitions/PropertyDefinitions.cs
src/libraries/System.Reflection.Metadata/src/System/Reflection/Internal/Utilities/MemoryBlock.cs
src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/Ecma335/Encoding/ControlFlowBuilder.cs
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.Get.CornerCases.cs
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_DeclaredFieldTests.cs
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_DeclaredMemberTests.cs
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_DeclaredMethodTests.cs
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_DeclaredNestedTypeTests.cs
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_DeclaredPropertiesTests.cs
src/libraries/System.Reflection/tests/TypeInfoTests.cs
src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/CacheExpires.cs
src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/CacheUsage.cs
src/libraries/System.Runtime.Handles/tests/SafeHandle.cs
src/libraries/System.Runtime.Loader/tests/ReferencedClassLib/ReferencedClassLib.cs
src/libraries/System.Runtime.Loader/tests/ReferencedClassLibNeutralIsSatellite/ReferencedClassLibNeutralIsSatellite.cs
src/libraries/System.Runtime.Loader/tests/SatelliteAssemblies.cs
src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/ObjectManager.cs
src/libraries/System.Runtime.Serialization.Xml/tests/SerializationTestTypes/DataContract.cs
src/libraries/System.Runtime.Serialization.Xml/tests/SerializationTestTypes/SampleIObjectRef.cs
src/libraries/System.Runtime.Serialization.Xml/tests/SerializationTestTypes/SampleTypes.cs
src/libraries/System.Runtime.Serialization.Xml/tests/SerializationTypes.RuntimeOnly.cs
src/libraries/System.Runtime.Serialization.Xml/tests/SerializationTypes.cs
src/libraries/System.Runtime/tests/System/DelegateTests.cs
src/libraries/System.Runtime/tests/System/PseudoCustomAttributeTests.cs
src/libraries/System.Runtime/tests/System/Reflection/IsCollectibleTests.cs
src/libraries/System.Runtime/tests/System/Reflection/TypeTests.Get.CornerCases.cs
src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/CipherReference.cs
src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Transform.cs
src/libraries/System.Security.Cryptography.Xml/tests/XmlDsigBase64TransformTest.cs
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/FeedUtils.cs
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/SyndicationFeedFormatter.cs
src/libraries/System.Text.Json/tests/Serialization/Stream.WriteTests.cs
src/libraries/System.Text.Json/tests/Serialization/TestClasses.Polymorphic.cs
src/libraries/System.Text.Json/tests/Serialization/TestClasses.SimpleTestClassWithObject.cs
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Match.cs
src/libraries/System.Threading.Tasks.Dataflow/src/Base/DataflowBlockOptions.cs
src/libraries/System.Threading.Tasks/tests/Task/TaskAPMTest.cs