selftests: net: tcp_mmap: use madvise(MADV_DONTNEED)
authorEric Dumazet <edumazet@google.com>
Thu, 20 Aug 2020 17:11:16 +0000 (10:11 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Aug 2020 23:14:53 +0000 (16:14 -0700)
commit0d89419319ef68f8acc1b78377ad3e7523fead4a
treef08c02e3cce3b6a2e536374fb12886651c72833d
parent394fcd8a813456b3306c423ec4227ed874dfc08b
selftests: net: tcp_mmap: use madvise(MADV_DONTNEED)

When TCP_ZEROCOPY_RECEIVE operation has been added,
I made the mistake of automatically un-mapping prior
content before mapping new pages.

This has the unfortunate effect of adding potentially long
MMU operations (like TLB flushes) while socket lock is held.

Using madvise(MADV_DONTNEED) right after pages has been used
has two benefits :

1) This releases pages sooner, allowing pages to be recycled
if they were part of a page pool in a NIC driver.

2) No more long unmap operations while preventing immediate
processing of incoming packets.

The cost of the added system call is small enough.

Arjun will submit a kernel patch allowing to opt out from
the unmap attempt in tcp_zerocopy_receive()

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Arjun Roy <arjunroy@google.com>
Cc: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/tcp_mmap.c