Add visibility="protected" attribute for global variables referenced in asm files.
authorRahul Chaudhry <rahulchaudhry@google.com>
Tue, 9 May 2017 19:00:58 +0000 (12:00 -0700)
committerRahul Chaudhry <rahulchaudhry@google.com>
Fri, 12 May 2017 18:11:16 +0000 (11:11 -0700)
commit0d88e15454b632d92404dd6a7181c58d9985e2a2
tree9c1275344ee02b18cc13326bed7e6c048ace8de2
parent9a665826049e421b9d80db7599a0120dc670654d
Add visibility="protected" attribute for global variables referenced in asm files.

During aosp builds with binutils-2.27, we're seeing linker error
messages of this form:
libvpx.a(subpixel_mmx.o): relocation R_386_GOTOFF against preemptible
symbol vp8_bilinear_filters_x86_8 cannot be used when making a shared
object

subpixel_mmx.o is assembled from "vp8/common/x86/subpixel_mmx.asm".
Other messages refer to symbol references from deblock_sse2.o and
subpixel_sse2.o, also assembled from asm files.

This change marks such symbols as having "protected" visibility. This
satisfies the linker as the symbols are not preemptible from outside
the shared library now, which I think is the original intent anyway.

Change-Id: I2817f7a5f43041533d65ebf41aefd63f8581a452
vp8/common/x86/filter_x86.c
vpx_dsp/deblock.c
vpx_ports/mem.h