projects / platform / upstream / qttools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ccad330) | patch
Don't use the QRegExp methods that modify the object [Assistant]
authorThiago Macieira <thiago.macieira@intel.com>
Mon, 23 Apr 2012 15:46:29 +0000 (17:46 +0200)
committerQt by Nokia <qt-info@nokia.com>
Mon, 23 Apr 2012 16:06:07 +0000 (18:06 +0200)
commit0d7f65edc58fb61311a707abd51d25e8af17ff3a
tree77a801fb4fa2fd7b5cc1b1cd73581878bc36f149tree | snapshot
parentccad330d82d24a6175efeea10610f400ca69f244commit | diff
Don't use the QRegExp methods that modify the object [Assistant]

QRegExp matching methods modify the object, which we don't want to. In
particular, when we receive a QRegExp from the user or we store in a
context that might require thread-safety, make sure we make a copy
before using it.

QRegularExpression has no such shortcoming.

Task-number: QTBUG-25064
Change-Id: I63bdca450db06adf1935672ca678b779cd89f961
Reviewed-by: Karsten Heimrich <karsten.heimrich@nokia.com>
src/assistant/help/qhelp_global.cpp diff | blob | history
src/assistant/help/qhelpgenerator.cpp diff | blob | history
src/assistant/help/qhelpsearchquerywidget.cpp diff | blob | history
Domain: UI Framework / Qt;