ipv6: remove extra dev_hold() for fallback tunnels
authorEric Dumazet <edumazet@google.com>
Wed, 31 Mar 2021 21:38:11 +0000 (14:38 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 31 Mar 2021 21:53:11 +0000 (14:53 -0700)
commit0d7a7b2014b1a499a0fe24c9f3063d7856b5aaaf
tree12b5dab56d531a8bae82ed9d97af97ac3e31d217
parentac1db7acea67777be1ba86e36e058c479eab6508
ipv6: remove extra dev_hold() for fallback tunnels

My previous commits added a dev_hold() in tunnels ndo_init(),
but forgot to remove it from special functions setting up fallback tunnels.

Fallback tunnels do call their respective ndo_init()

This leads to various reports like :

unregister_netdevice: waiting for ip6gre0 to become free. Usage count = 2

Fixes: 48bb5697269a ("ip6_tunnel: sit: proper dev_{hold|put} in ndo_[un]init methods")
Fixes: 6289a98f0817 ("sit: proper dev_{hold|put} in ndo_[un]init methods")
Fixes: 40cb881b5aaa ("ip6_vti: proper dev_{hold|put} in ndo_[un]init methods")
Fixes: 7f700334be9a ("ip6_gre: proper dev_{hold|put} in ndo_[un]init methods")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ip6_gre.c
net/ipv6/ip6_tunnel.c
net/ipv6/ip6_vti.c
net/ipv6/sit.c