spi: spi-sun6i: Fix chipselect/clock bug
authorMirko Vogt <mirko-dev|linux@nanl.de>
Mon, 14 Jun 2021 14:45:07 +0000 (16:45 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 23 Jun 2021 10:48:36 +0000 (11:48 +0100)
commit0d7993b234c9fad8cb6bec6adfaa74694ba85ecb
treee26dd110cf6105242f02ae086d79ca6d1037ac24
parentf422316c8e9d3c4aff3c56549dfb44a677d02f14
spi: spi-sun6i: Fix chipselect/clock bug

The current sun6i SPI implementation initializes the transfer too early,
resulting in SCK going high before the transfer. When using an additional
(gpio) chipselect with sun6i, the chipselect is asserted at a time when
clock is high, making the SPI transfer fail.

This is due to SUN6I_GBL_CTL_BUS_ENABLE being written into
SUN6I_GBL_CTL_REG at an early stage. Moving that to the transfer
function, hence, right before the transfer starts, mitigates that
problem.

Fixes: 3558fe900e8af (spi: sunxi: Add Allwinner A31 SPI controller driver)
Signed-off-by: Mirko Vogt <mirko-dev|linux@nanl.de>
Signed-off-by: Ralf Schlatterbeck <rsc@runtux.com>
Link: https://lore.kernel.org/r/20210614144507.y3udezjfbko7eavv@runtux.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sun6i.c