x86/boot: Fix memory leak in default_get_smp_config()
authorDavid Rientjes <rientjes@google.com>
Wed, 10 Jul 2019 02:44:03 +0000 (19:44 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Jul 2019 07:14:25 +0000 (09:14 +0200)
commit0d4c0bb706653ebc52cbf5adaa68d73f108488c2
treeaab57806e53839ae4a4a3c6ce518f5238b73589d
parentb52807e607f19d763ad19c2cdfcb7ef834a15259
x86/boot: Fix memory leak in default_get_smp_config()

commit e74bd96989dd42a51a73eddb4a5510a6f5e42ac3 upstream.

When default_get_smp_config() is called with early == 1 and mpf->feature1
is non-zero, mpf is leaked because the return path does not do
early_memunmap().

Fix this and share a common exit routine.

Fixes: 5997efb96756 ("x86/boot: Use memremap() to map the MPF and MPC data")
Reported-by: Cfir Cohen <cfir@google.com>
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907091942570.28240@chino.kir.corp.google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/kernel/mpparse.c