net: throw on invalid socket timeouts
authorcjihrig <cjihrig@gmail.com>
Tue, 16 Dec 2014 22:17:28 +0000 (17:17 -0500)
committercjihrig <cjihrig@gmail.com>
Fri, 13 Feb 2015 18:37:24 +0000 (13:37 -0500)
commit0cff0521c333df8649bc6a2b1f40adbf899b1261
treee340b83cdfd414829abd13220eb16af1c87366ef
parentba40942ad22c8dd0dc7699370c6d3867c99267bc
net: throw on invalid socket timeouts

This commit restricts socket timeouts non-negative, finite
numbers. Any other value throws a TypeError or RangeError.
This prevents subtle bugs that can happen due to type
coercion.

Fixes: https://github.com/joyent/node/issues/8618
PR-URL: https://github.com/joyent/node/pull/8884
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
Conflicts:
lib/timers.js
test/simple/test-net-settimeout.js
test/simple/test-net-socket-timeout.js
lib/net.js
lib/timers.js
test/parallel/test-net-settimeout.js
test/parallel/test-net-socket-timeout.js