media: v4l2-core: fix uninitialized structure fields being returned to userspace
authorColin Ian King <colin.king@canonical.com>
Tue, 7 Jan 2020 14:02:06 +0000 (15:02 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 9 Jan 2020 14:26:18 +0000 (15:26 +0100)
commit0c8c1ae155b89be7e0cd7e74494dfc83554c56d2
treef535b7b2ffba5c076717b1fb59a0b76679ccfe6a
parentbaf98b0ad304e1959222c51b9ffc5c8f85865ca0
media: v4l2-core: fix uninitialized structure fields being returned to userspace

In the case where v4l2_event_dequeue fails the structure ev is not
being filled and this garbage data from the stack is being copied
to the ev32 structure and being copied back to userspace on the
VIDIOC_DQEVENT_TIME32 ioctl.  Fix this by ensuring the ev structure
is zero'd to ensure uninitialized data is not leaked back.

Addresses-Coverity: ("Uninitialized scalar variable")

Fixes: 1a6c0b36dd19 ("media: v4l2-core: fix VIDIOC_DQEVENT for time64 ABI")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/v4l2-core/v4l2-subdev.c