xfs: fix inverted return from xfs_btree_sblock_verify_crc
authorEric Sandeen <sandeen@redhat.com>
Mon, 4 Feb 2019 16:54:27 +0000 (08:54 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Feb 2019 18:47:21 +0000 (19:47 +0100)
commit0c802cbaa6db4203fc559829548e19ae5ee8c9c2
treed6ebf195bae65ce8a4704df28f71b5e66bcfd6a2
parentc6c20af69c617121331e231f797893d9dca0c9c5
xfs: fix inverted return from xfs_btree_sblock_verify_crc

commit 7d048df4e9b05ba89b74d062df59498aa81f3785 upstream.

xfs_btree_sblock_verify_crc is a bool so should not be returning
a failaddr_t; worse, if xfs_log_check_lsn fails it returns
__this_address which looks like a boolean true (i.e. success)
to the caller.

(interestingly xfs_btree_lblock_verify_crc doesn't have the issue)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/xfs/libxfs/xfs_btree.c