Always run CopyAllNativeProjectReferenceBinaries (#67718)
authorTomáš Rylek <trylek@microsoft.com>
Sat, 9 Apr 2022 14:03:45 +0000 (16:03 +0200)
committerGitHub <noreply@github.com>
Sat, 9 Apr 2022 14:03:45 +0000 (16:03 +0200)
commit0c64bdf3afc1fdc9166ad6c22c1990d3e0a6c509
tree14a6bae08a321156bffc2d58b7036b9e83b8a06b
parent3537bf20373e2c6fd01d4e2d477be1b6d5be51d9
Always run CopyAllNativeProjectReferenceBinaries (#67718)

Previously this target was only called from the recursive traversal
used when globally copying native artifacts for all projects (this
is used in the lab where the native artifacts are produced on
a different machine than the managed test artifacts). In case of
combined (local) test build we weren't running the target, only
its dependencies (ResolveCMakeNativeProjectReference and
ConsolidateNativeProjectReference); this used to be sufficient as
these two targets handle all logic related to copying native
components of a normal project, however I have recently added
special logic for copying merged test wrapper native artifacts
the CopyAllNativeProjectReferenceBinaries target and so we now must
make sure it also always runs.

Mark JIT optimization-sensitive tests as out-of-process and fix
logic around skipping of out-of-process tests on the excluded platforms.

Fix GetFilteredExcludeList to properly report out-of-process tests

Add issues.targets exclusions for compat_i4_u_il_d / compat_i4_u_il_r
on all Mono platforms

Log timestamps in generated wrapper for investigation of timeouts

Log timestamps around Crossgen2 invocations for investigation of timeouts

Suppress noisy stderr spew for deletion of non-existent rsp files

Expand test timeout to 30 minutes

In the merged scenario we're intentionally reducing the number of
work items at the expense of a single work item size. When
Crossgen2 compilation is involved, with hundreds of tests in the
Methodical_*** projects we're hitting the 15 minute test timeout
so I'm bumping it up to 30. I have also suppressed uninteresting
stderr spew from deletion of the pre-existing composite image.

Thanks

Tomas
src/tests/Common/CLRTest.CrossGen.targets
src/tests/Common/CoreCLRTestLibrary/OutOfProcessTest.cs
src/tests/Common/XUnitWrapperGenerator/ITestInfo.cs
src/tests/Directory.Build.targets
src/tests/JIT/Methodical/Arrays/misc/arrres_il_r.ilproj
src/tests/JIT/Methodical/tailcall_v4/hijacking.ilproj
src/tests/issues.targets
src/tests/run.py