linux-user: remove duplicate tswap32() from do_getsockopt()
authorLaurent Vivier <laurent@vivier.eu>
Mon, 1 Jun 2009 21:57:48 +0000 (23:57 +0200)
committerRiku Voipio <riku.voipio@nokia.com>
Tue, 16 Jun 2009 13:58:45 +0000 (16:58 +0300)
commit0c40c6c4fc1f38775b2b7d185a8aa35bde7846f5
tree18f943659ece1bb8d8d4b2e5d42e0e913ea3b345
parentcf647d879980aaabf30cea9c315f3de7cc2fa2fd
linux-user: remove duplicate tswap32() from do_getsockopt()

This issue has been detected with tests/linux-tests.c:

linux-test.c:330: getsockopt

327     len = sizeof(val);
328     chk_error(getsockopt(server_fd, SOL_SOCKET, SO_TYPE, &val, &len));
329     if (val != SOCK_STREAM)
330         error("getsockopt");

In linux-user/syscall.c:do_getsockopt(), we have:
...
        val = tswap32(val);
...
            if (put_user_u32(val, optval_addr))
...

whereas "put_user_u32" calls in the end "__put_user" which uses "tswap32".

So the "val = tswap32(val);" is useless and wrong.

This patch removes it.

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
linux-user/syscall.c