xfs: don't serialise direct IO reads on page cache checks
authorDave Chinner <dchinner@redhat.com>
Thu, 25 Aug 2011 07:17:01 +0000 (07:17 +0000)
committerAlex Elder <aelder@sgi.com>
Wed, 12 Oct 2011 02:14:59 +0000 (21:14 -0500)
commit0c38a2512df272b14ef4238b476a2e4f70da1479
treea88374d18dc0d28521d74bbf9ccde245ccaccdda
parent976d167615b64e14bc1491ca51d424e2ba9a5e84
xfs: don't serialise direct IO reads on page cache checks

There is no need to grab the i_mutex of the IO lock in exclusive
mode if we don't need to invalidate the page cache. Taking these
locks on every direct IO effective serialises them as taking the IO
lock in exclusive mode has to wait for all shared holders to drop
the lock. That only happens when IO is complete, so effective it
prevents dispatch of concurrent direct IO reads to the same inode.

Fix this by taking the IO lock shared to check the page cache state,
and only then drop it and take the IO lock exclusively if there is
work to be done. Hence for the normal direct IO case, no exclusive
locking will occur.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Tested-by: Joern Engel <joern@logfs.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/xfs_file.c