ipack/carriers/tpci200: Fix a double free in tpci200_pci_probe
authorLv Yunlong <lyl2019@mail.ustc.edu.cn>
Mon, 24 May 2021 09:32:05 +0000 (02:32 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 07:45:01 +0000 (09:45 +0200)
commit0c2bc1489104abcc738b5762a3de6238fd23ffa5
tree99b75fac4403fb83f09f8e038cb9f3abe1653da3
parenteb81b5a37dc55e8d8042c81672bf7b0e24ff89e1
ipack/carriers/tpci200: Fix a double free in tpci200_pci_probe

commit 9272e5d0028d45a3b45b58c9255e6e0df53f7ad9 upstream.

In the out_err_bus_register error branch of tpci200_pci_probe,
tpci200->info->cfg_regs is freed by tpci200_uninstall()->
tpci200_unregister()->pci_iounmap(..,tpci200->info->cfg_regs)
in the first time.

But later, iounmap() is called to free tpci200->info->cfg_regs
again.

My patch sets tpci200->info->cfg_regs to NULL after tpci200_uninstall()
to avoid the double free.

Fixes: cea2f7cdff2af ("Staging: ipack/bridges/tpci200: Use the TPCI200 in big endian mode")
Cc: stable <stable@vger.kernel.org>
Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Link: https://lore.kernel.org/r/20210524093205.8333-1-lyl2019@mail.ustc.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/ipack/carriers/tpci200.c