iio: adc: xilinx-ams: Fix single channel switching sequence
authorRobert Hancock <robert.hancock@calian.com>
Thu, 27 Jan 2022 17:34:50 +0000 (11:34 -0600)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 2 Mar 2022 13:39:08 +0000 (13:39 +0000)
commit0bf126163c3e7e6d722622073046aed567a5551e
tree3c8296b480f428c20628f9eeaea77853b2987d67
parentd5d786fb531697be74c567b3844c6897ddf1ffdd
iio: adc: xilinx-ams: Fix single channel switching sequence

Some of the AMS channels need to be read by switching into single-channel
mode from the normal polling sequence. There was a logic issue in this
switching code that could cause the first read of these channels to read
back as zero.

It appears that the sequencer should be set back to default mode before
changing the channel selection, and the channel should be set before
switching the sequencer back into single-channel mode.

Also, write 1 to the EOC bit in the status register to clear it before
waiting for it to become set, so that we actually wait for a new
conversion to complete, and don't proceed based on a previous conversion
completing.

Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
Signed-off-by: Robert Hancock <robert.hancock@calian.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/20220127173450.3684318-5-robert.hancock@calian.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/xilinx-ams.c