sunrpc: Don't schedule an upcall on a replaced cache entry.
authorNeilBrown <neilb@suse.de>
Thu, 13 Jun 2013 02:53:42 +0000 (12:53 +1000)
committerJ. Bruce Fields <bfields@redhat.com>
Mon, 1 Jul 2013 21:53:28 +0000 (17:53 -0400)
commit0bebc633f1428163c9659fd16b34c745e60a0757
tree4534e9fe01086a6b9a860b2654d102ad4515e052
parent7715cde86857d4bb40f43f1ee971cf906eaf1b9c
sunrpc: Don't schedule an upcall on a replaced cache entry.

When a cache entry is replaced, the "expiry_time" get set to
zero by a call to "cache_fresh_locked(..., 0)" at the end of
"sunrpc_cache_update".

This low expiry time makes cache_check() think that the 'refresh_age'
is negative, so the 'age' is comparatively large and a refresh is
triggered.
However refreshing a replaced entry it pointless, it cannot achieve
anything useful.

So teach cache_check to ignore a low refresh_age when expiry_time
is zero.

Reported-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/cache.c