[InstCombine] canonicalize cast before unary shuffle
authorSanjay Patel <spatel@rotateright.com>
Tue, 25 May 2021 11:52:48 +0000 (07:52 -0400)
committerSanjay Patel <spatel@rotateright.com>
Tue, 25 May 2021 12:43:09 +0000 (08:43 -0400)
commit0bab0f6161193cd0cd24b7b0fc51590a60e810d2
treeaf41afd5fd5af20e6d7fa11a40bfa848de6ea947
parent06eae35689ee1a190cc3f2310e289b2659654755
[InstCombine] canonicalize cast before unary shuffle

We could go either direction on this transform. VectorCombine already goes this
way for bitcasts (and handles more complicated cases using the cost model), so
let's try cast-first.

Deferring completely to VectorCombine is another possibility. But the backend
should be able to invert this easily when the vectors have the same shape, so
it doesn't seem like a transform that we need to avoid.

The motivating example from https://llvm.org/PR49081 has an int-to-float
sandwiched between 2 shuffles, and the backend currently does not reduce that,
so on x86, we get something like:

  pshufd $249, %xmm0, %xmm0]
  cvtdq2ps %xmm0, %xmm0
  shufps $144, %xmm0, %xmm0

...instead of just a single conversion instruction.

Differential Revision: https://reviews.llvm.org/D103038
llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp
llvm/test/Transforms/InstCombine/X86/x86-f16c-inseltpoison.ll
llvm/test/Transforms/InstCombine/X86/x86-f16c.ll
llvm/test/Transforms/InstCombine/shuffle-cast-dist.ll
llvm/test/Transforms/InstCombine/shufflevec-bitcast-inseltpoison.ll
llvm/test/Transforms/InstCombine/shufflevec-bitcast.ll
llvm/test/Transforms/InstCombine/vector-casts.ll