md: always set MD_RECOVERY_INTR when aborting a reshape or other "resync".
authorNeilBrown <neilb@suse.de>
Wed, 28 May 2014 03:39:23 +0000 (13:39 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Jun 2014 19:04:11 +0000 (12:04 -0700)
commit0b78a4287b8cc7c0817b7bc4894d8c9c177bb751
treea79f52db36124cced0f72ad992b7d7d05b603ec7
parentd6e81d4f7b4e8cea2817c7568e3756798cd29aae
md: always set MD_RECOVERY_INTR when aborting a reshape or other "resync".

commit 3991b31ea072b070081ca3bfa860a077eda67de5 upstream.

If mddev->ro is set, md_to_sync will (correctly) abort.
However in that case MD_RECOVERY_INTR isn't set.

If a RESHAPE had been requested, then ->finish_reshape() will be
called and it will think the reshape was successful even though
nothing happened.

Normally a resync will not be requested if ->ro is set, but if an
array is stopped while a reshape is on-going, then when the array is
started, the reshape will be restarted.  If the array is also set
read-only at this point, the reshape will instantly appear to success,
resulting in data corruption.

Consequently, this patch is suitable for any -stable kernel.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/md.c