libio: Flush stream at freopen (BZ#21037)
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Thu, 13 Jul 2017 19:43:24 +0000 (16:43 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Tue, 2 Oct 2018 13:01:56 +0000 (10:01 -0300)
commit0b727ed4d605d9318cb0d323c88abb0d5a441a9b
tree456efbab739f291b486ee8d937703cb0d4db5cef
parentd0e91e8c4ef77997c940538eaa752799c9dda2d3
libio: Flush stream at freopen (BZ#21037)

As POSIX states [1] a freopen call should first flush the stream as if by a
call fflush.  C99 (n1256) and C11 (n1570) only states the function should
first close any file associated with the specific stream.  Although current
implementation only follow C specification, current BSD and other libc
implementation (musl) are in sync with POSIX and fflush the stream.

This patch change freopen{64} to fflush the stream before actually reopening
it (or returning if the stream does not support reopen).  It also changes the
Linux implementation to avoid a dynamic allocation on 'fd_to_filename'.

Checked on x86_64-linux-gnu.

[BZ #21037]
* libio/Makefile (tests): Add tst-memstream4 and tst-wmemstream4.
* libio/freopen.c (freopen): Sync stream before reopen and adjust to
new fd_to_filename interface.
* libio/freopen64.c (freopen64): Likewise.
* libio/tst-memstream.h: New file.
* libio/tst-memstream4.c: Likewise.
* libio/tst-wmemstream4.c: Likewise.
* sysdeps/generic/fd_to_filename.h (fd_to_filename): Change signature.
* sysdeps/unix/sysv/linux/fd_to_filename.h (fd_to_filename): Likewise
and remove internal dynamic allocation.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/
ChangeLog
libio/Makefile
libio/freopen.c
libio/freopen64.c
libio/tst-memstream.h [new file with mode: 0644]
libio/tst-memstream4.c [new file with mode: 0644]
libio/tst-wmemstream4.c [new file with mode: 0644]
sysdeps/generic/fd_to_filename.h
sysdeps/unix/sysv/linux/fd_to_filename.h