drm/i915/guc: index host arrays by i915 engine ID, not guc_id
authorDave Gordon <david.s.gordon@intel.com>
Mon, 20 Jun 2016 14:18:07 +0000 (15:18 +0100)
committerTvrtko Ursulin <tvrtko.ursulin@intel.com>
Tue, 21 Jun 2016 10:24:25 +0000 (11:24 +0100)
commit0b63bb1412bf9b2d72d60e38d07bd9dfe657a382
tree51d705c4b68c026dac5a3d7a473c8c64453bbe84
parente77018f7618960f7ec0e73e63868514ff16f8ddc
drm/i915/guc: index host arrays by i915 engine ID, not guc_id

The ONLY places that guc_id (aka hw_id) should be used are those where
the value or address is determined by and shared with the GuC firmware;
specifically, when filling in the GuC-context-descriptor or the GuC
addon data, or putting an entry in the GuC's work queue.

It need not (and therefore should not) be used to index GuC statistics
or similar host-managed tracking data. In particular, i915_guc_submit()
produces (and debugfs decodes) GuC submission statistics which should be
indexed by driver-engine-id rather then guc-engine-id.

Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1466432287-5799-1-git-send-email-david.s.gordon@intel.com
drivers/gpu/drm/i915/i915_debugfs.c
drivers/gpu/drm/i915/i915_guc_submission.c
drivers/gpu/drm/i915/intel_guc.h