[AArch64][Windows] Compute function length correctly in unwind tables.
authorEli Friedman <efriedma@quicinc.com>
Fri, 3 May 2019 00:10:45 +0000 (00:10 +0000)
committerEli Friedman <efriedma@quicinc.com>
Fri, 3 May 2019 00:10:45 +0000 (00:10 +0000)
commit0b61d220c9b1f00e79d5457b9b8d2f046e49776c
tree36ac5debf5669b03a79b14cd6afd1ae5f2441a36
parent973d66eefcbbe3dc3a147f73435498846debb872
[AArch64][Windows] Compute function length correctly in unwind tables.

The primary fix here is to WinException.cpp: we need to exclude jump
tables when computing the length of a function, or else we fail to
correctly compute the length. (We can only compute the number of bytes
consumed by certain assembler directives after the entire file is
parsed. ".p2align" is one of those directives, and is used by jump table
generation.)

The secondary fix, to MCWin64EH, is to make sure we don't silently
miscompile if we hit a similar situation in the future.

It's possible we could extend ARM64EmitUnwindInfo so it allows function
bodies that contain assembler directives, but that's a lot more
complicated; see the FIXME in MCWin64EH.cpp.

Fixes https://bugs.llvm.org/show_bug.cgi?id=41581 .

Differential Revision: https://reviews.llvm.org/D61095

llvm-svn: 359849
llvm/lib/CodeGen/AsmPrinter/WinException.cpp
llvm/lib/CodeGen/AsmPrinter/WinException.h
llvm/lib/MC/MCWin64EH.cpp
llvm/test/CodeGen/AArch64/win64-jumptable.ll