rust: types: make `Opaque` be `!Unpin`
authorBenno Lossin <benno.lossin@proton.me>
Fri, 30 Jun 2023 15:03:23 +0000 (15:03 +0000)
committerMiguel Ojeda <ojeda@kernel.org>
Wed, 9 Aug 2023 23:18:34 +0000 (01:18 +0200)
commit0b4e3b6f6b79b1add04008a6ceaaf661107e8902
treeb02ce71b84124f5f6320d35d660fa5cda46a2622
parent35cad617df2eeef8440a38e82bb2d81ae32ca50d
rust: types: make `Opaque` be `!Unpin`

Adds a `PhantomPinned` field to `Opaque<T>`. This removes the last Rust
guarantee: the assumption that the type `T` can be freely moved. This is
not the case for many types from the C side (e.g. if they contain a
`struct list_head`). This change removes the need to add a
`PhantomPinned` field manually to Rust structs that contain C structs
which must not be moved.

Signed-off-by: Benno Lossin <benno.lossin@proton.me>
Reviewed-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Andreas Hindborg <a.hindborg@samsung.com>
Link: https://lore.kernel.org/r/20230630150216.109789-1-benno.lossin@proton.me
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
rust/kernel/types.rs