s390/qeth: fix initialization on old HW
authorJulian Wiedmann <jwi@linux.ibm.com>
Mon, 23 Dec 2019 14:03:26 +0000 (15:03 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jan 2020 18:48:27 +0000 (19:48 +0100)
commit0b3e622f8ccc1f6017b3fb6ae406ebd73489d1f4
treee588754e29cdf6372a9571cfbf2df21decbedd49
parentccdd5b39773d2fdecc96804a7db7683469df765d
s390/qeth: fix initialization on old HW

commit 0b698c838e84149b690c7e979f78cccb6f8aa4b9 upstream.

I stumbled over an old OSA model that claims to support DIAG_ASSIST,
but then rejects the cmd to query its DIAG capabilities.

In the old code this was ok, as the returned raw error code was > 0.
Now that we translate the raw codes to errnos, the "rc < 0" causes us
to fail the initialization of the device.

The fix is trivial: don't bail out when the DIAG query fails. Such an
error is not critical, we can still use the device (with a slightly
reduced set of features).

Fixes: 742d4d40831d ("s390/qeth: convert remaining legacy cmd callbacks")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/s390/net/qeth_core_main.c