Arm: Fix disassembler crashing on -b binary when thumb file and thumb not forced.
authorTamar Christina <tamar.christina@arm.com>
Fri, 19 Oct 2018 09:31:42 +0000 (10:31 +0100)
committerTamar Christina <tamar.christina@arm.com>
Fri, 19 Oct 2018 09:33:11 +0000 (10:33 +0100)
commit0b347048e7e33070212a408dc2371075ee60b556
tree55dfcb25a5e55e764242fab9898b76cde0f92e12
parent33d64ca5db656f1f377de18f94403d8b3b91e3a1
Arm: Fix disassembler crashing on -b binary when thumb file and thumb not forced.

The disassembler for Arm has some aborts in it in places it assumes can never
be reached.  Under normal circumstances they indeed cannot be reached because
the right options are selected from the ARM attributes in the ELF file.

However when disassembling with -b binary then if you do not get the options
right the disassembler just aborts.  This changes it so it just prints how it
was trying to interpret the instruction and prints UNKNOWN instructions next to it.

This way the user has an idea of what's going.

gas/ChangeLog:

* testsuite/gas/arm/undefined-insn-arm.d: New test.
* testsuite/gas/arm/undefined-insn-thumb.d: New test.
* testsuite/gas/arm/undefined-insn.s: New test.

opcodes/ChangeLog:

* arm-dis.c (UNKNOWN_INSTRUCTION_32BIT): Format specifier for arm mode.
(UNKNOWN_INSTRUCTION_16BIT): Format specifier for thumb mode.
(print_insn_arm, print_insn_thumb16, print_insn_thumb32): Use them.
gas/ChangeLog
gas/testsuite/gas/arm/undefined-insn-arm.d [new file with mode: 0644]
gas/testsuite/gas/arm/undefined-insn-thumb.d [new file with mode: 0644]
gas/testsuite/gas/arm/undefined-insn.s [new file with mode: 0644]
opcodes/ChangeLog
opcodes/arm-dis.c