irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 1 Jun 2022 08:09:28 +0000 (12:09 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Jun 2022 12:22:02 +0000 (14:22 +0200)
commit0b325d993995a321f6ab4e6c51f0504ec092bf5b
treebe7d415c32efc24dce597f2f4307b047a5601e4b
parent5d38720661a4b9c87705c206a6081177ffb8ec1d
irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions

[ Upstream commit ec8401a429ffee34ccf38cebf3443f8d5ae6cb0d ]

of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
When kcalloc fails, it missing of_node_put() and results in refcount
leak. Fix this by goto out_put_node label.

Fixes: 52085d3f2028 ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-5-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-gic-v3.c