dmaengine: idxd: make submit failure path consistent on desc freeing
authorDave Jiang <dave.jiang@intel.com>
Fri, 6 Aug 2021 17:37:40 +0000 (10:37 -0700)
committerVinod Koul <vkoul@kernel.org>
Wed, 25 Aug 2021 11:30:24 +0000 (17:00 +0530)
commit0b030f54f094fcd42f4a607a675c1851129a58c8
tree679418b53ef62fcf2e12685d764acc36930e06f0
parent9760383b22edbfa407a1647969c26d62a501631f
dmaengine: idxd: make submit failure path consistent on desc freeing

The submission path for dmaengine API does not do descriptor freeing on
failure. Also, with the abort mechanism, the freeing of descriptor happens
when the abort callback is completed. Therefore free descriptor on all
error paths for submission call to make things consistent. Also remove the
double free that would happen on abort in idxd_dma_tx_submit() call.

Fixes: 6b4b87f2c31a ("dmaengine: idxd: fix submission race window")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/162827146072.3459011.10255348500504659810.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/dma.c
drivers/dma/idxd/submit.c