media: em28xx: fix memory leak
authorMuhammad Usama Anjum <musamaanjum@gmail.com>
Wed, 24 Mar 2021 18:07:53 +0000 (19:07 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 6 Apr 2021 08:36:58 +0000 (10:36 +0200)
commit0ae10a7dc8992ee682ff0b1752ff7c83d472eef1
tree862341f7a5da9bb8f6b822a73d7aac999e88b7fe
parent73c9a3f3b3465be8b7c71ba736c2696290a43bf8
media: em28xx: fix memory leak

If some error occurs, URB buffers should also be freed. If they aren't
freed with the dvb here, the em28xx_dvb_fini call doesn't frees the URB
buffers as dvb is set to NULL. The function in which error occurs should
do all the cleanup for the allocations it had done.

Tested the patch with the reproducer provided by syzbot. This patch
fixes the memleak.

Reported-by: syzbot+889397c820fa56adf25d@syzkaller.appspotmail.com
Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/em28xx/em28xx-dvb.c