ceph: don't skip updating wanted caps when cap is stale
authorYan, Zheng <zyan@redhat.com>
Tue, 10 Mar 2020 11:34:20 +0000 (19:34 +0800)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 30 Mar 2020 10:42:43 +0000 (12:42 +0200)
commit0aa971b6fd3f92afef6afe24ef78d9bb14471519
tree96ba1545559e3c9dd2b29acaee2fb649f4e96862
parent42d70f8e31dfd3b795259b0d5c7ff4d4b45c24fd
ceph: don't skip updating wanted caps when cap is stale

1. try_get_cap_refs() fails to get caps and finds that mds_wanted
   does not include what it wants. It returns -ESTALE.
2. ceph_get_caps() calls ceph_renew_caps(). ceph_renew_caps() finds
   that inode has cap, so it calls ceph_check_caps().
3. ceph_check_caps() finds that issued caps (without checking if it's
   stale) already includes caps wanted by open file, so it skips
   updating wanted caps.

Above events can cause an infinite loop inside ceph_get_caps().

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/caps.c