usb: ulpi: Call of_node_put correctly
authorSean Anderson <sean.anderson@seco.com>
Thu, 27 Jan 2022 19:00:03 +0000 (14:00 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Jan 2022 13:11:20 +0000 (14:11 +0100)
commit0a907ee9d95e3ac35eb023d71f29eae0aaa52d1b
tree2d688408d9b8d8f05828365c3481fb0f6bc78f86
parent092f45b13e51666fe8ecbf2d6cd247aa7e6c1f74
usb: ulpi: Call of_node_put correctly

of_node_put should always be called on device nodes gotten from
of_get_*. Additionally, it should only be called after there are no
remaining users. To address the first issue, call of_node_put if later
steps in ulpi_register fail. To address the latter, call put_device if
device_register fails, which will call ulpi_dev_release if necessary.

Fixes: ef6a7bcfb01c ("usb: ulpi: Support device discovery via DT")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Link: https://lore.kernel.org/r/20220127190004.1446909-3-sean.anderson@seco.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/common/ulpi.c