Input: exc3000 - fix return value check of wait_for_completion_timeout
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 29 Jun 2022 05:42:35 +0000 (22:42 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:40:08 +0000 (11:40 +0200)
commit0a02159ae636d61504161edf473df1f7a863badf
tree9c01e7ee05d7d55e84e9540ed01c0341996ca774
parenta4a945641acaf37d37cd95255888f7f2268ccb0e
Input: exc3000 - fix return value check of wait_for_completion_timeout

commit 6bb7144c3fa16a5efb54a8e2aff1817b4168018e upstream.

wait_for_completion_timeout() returns unsigned long not int.
It returns 0 if timed out, and positive if completed.
The check for <= 0 is ambiguous and should be == 0 here
indicating timeout which is the only error case.

Fixes: 102feb1ddfd0 ("Input: exc3000 - factor out vendor data request")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220411105828.22140-1-linmq006@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/input/touchscreen/exc3000.c