analyzer: fix uninit false positive with -ftrivial-auto-var-init= [PR106204]
authorDavid Malcolm <dmalcolm@redhat.com>
Wed, 27 Jul 2022 21:38:55 +0000 (17:38 -0400)
committerDavid Malcolm <dmalcolm@redhat.com>
Wed, 27 Jul 2022 21:54:37 +0000 (17:54 -0400)
commit09cb9c88ef8e2c0c89ada9cde2caf1a960db7a77
tree78ec5491cb0c1e9e213fbfcf1f09ef1833cc1446
parent9fa11419ef59fde9d00ea8458235baa2bc83cd7a
analyzer: fix uninit false positive with -ftrivial-auto-var-init= [PR106204]

(cherry picked from r13-1517-gb33dd7874523af)

-fanalyzer handles -ftrivial-auto-var-init= by special-casing
IFN_DEFERRED_INIT to be a no-op, so that e.g.:

  len_2 = .DEFERRED_INIT (4, 2, &"len"[0]);

is treated as a no-op, so that len_2 is still uninitialized after the
stmt.

PR analyzer/106204 reports that -fanalyzer gives false positives from
-Wanalyzer-use-of-uninitialized-value on locals that have their address
taken, due to e.g.:

  _1 = .DEFERRED_INIT (4, 2, &"len"[0]);
  len = _1;

where -fanalyzer leaves _1 uninitialized, and then complains about
the assignment to "len".

Fixed thusly by suppressing the warning when assigning from such SSA
names.

gcc/analyzer/ChangeLog:
PR analyzer/106204
* region-model.cc (within_short_circuited_stmt_p): Move extraction
of assign_stmt to caller.
(due_to_ifn_deferred_init_p): New.
(region_model::check_for_poison): Move extraction of assign_stmt
from within_short_circuited_stmt_p to here.  Share logic with
call to due_to_ifn_deferred_init_p.

gcc/testsuite/ChangeLog:
PR analyzer/106204
* gcc.dg/analyzer/torture/uninit-pr106204.c: New test.
* gcc.dg/analyzer/uninit-pr106204.c: New test.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
gcc/analyzer/region-model.cc
gcc/testsuite/gcc.dg/analyzer/torture/uninit-pr106204.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/analyzer/uninit-pr106204.c [new file with mode: 0644]