ld: Add _bfd_elf_link_hide_sym_by_version
authorH.J. Lu <hjl.tools@gmail.com>
Sat, 26 May 2018 11:27:09 +0000 (04:27 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Sat, 26 May 2018 11:27:24 +0000 (04:27 -0700)
commit099bb8fb97d79d03a20926d6014a5fc27a5ca75e
treebb0da692186056971e42f952769ecf154378133e
parentd7460de3eadeb5b7665ad8569f54e59eccdef378
ld: Add _bfd_elf_link_hide_sym_by_version

bfd_hide_sym_by_version can't be used to check if a versioned symbol is
hidden.  This patch adds _bfd_elf_link_hide_sym_by_version to support
both versioned and unversioned symbols by extracting versioned symbol
check from _bfd_elf_link_assign_sym_version.

bfd/

PR ld/23194
* elf-bfd.h (_bfd_elf_link_hide_sym_by_version): New.
* elflink.c (_bfd_elf_link_hide_versioned_symbol): New function.
Extracted from _bfd_elf_link_assign_sym_version.
(_bfd_elf_link_hide_sym_by_version): New function.
(_bfd_elf_link_assign_sym_version): Use
_bfd_elf_link_hide_versioned_symbol.
* elfxx-x86.c (_bfd_x86_elf_link_symbol_references_local): Call
_bfd_elf_link_hide_sym_by_version instead of
bfd_hide_sym_by_version.  Don't check unversioned symbol.

ld/

PR ld/23194
* testsuite/ld-i386/pr23194.d: Expect only R_386_GLOB_DAT
against foobar.
* testsuite/ld-i386/pr23194.map: Add foobar.
* testsuite/ld-x86-64/pr23194.map: Likewise.
* testsuite/ld-i386/pr23194.s: Add a common foobar symbol.
* testsuite/ld-x86-64/pr23194.s: Likewise.
* testsuite/ld-x86-64/pr23194.d: Expect only R_X86_64_GLOB_DAT
against foobar.
bfd/ChangeLog
bfd/elf-bfd.h
bfd/elflink.c
bfd/elfxx-x86.c
ld/ChangeLog
ld/testsuite/ld-i386/pr23194.d
ld/testsuite/ld-i386/pr23194.map
ld/testsuite/ld-i386/pr23194.s
ld/testsuite/ld-x86-64/pr23194.d
ld/testsuite/ld-x86-64/pr23194.map
ld/testsuite/ld-x86-64/pr23194.s